better lighting

pxl8d/src/math.rs

@@ -1,42 +1,62 @@
 use core::ops::{Add, Mul, Sub};
 
-#[derive(Clone, Copy, Default)]
-pub struct Vec3 {
-    pub x: f32,
-    pub y: f32,
-    pub z: f32,
+use crate::pxl8::pxl8_vec3;
+
+pub type Vec3 = pxl8_vec3;
+
+pub const VEC3_ZERO: Vec3 = Vec3 { x: 0.0, y: 0.0, z: 0.0 };
+pub const VEC3_Y: Vec3 = Vec3 { x: 0.0, y: 1.0, z: 0.0 };
+
+pub trait Vec3Ext {
+    fn new(x: f32, y: f32, z: f32) -> Self;
+    fn dot(self, rhs: Self) -> f32;
 }
 
-impl Vec3 {
-    pub const ZERO: Self = Self { x: 0.0, y: 0.0, z: 0.0 };
-    pub const Y: Self = Self { x: 0.0, y: 1.0, z: 0.0 };
-
-    pub const fn new(x: f32, y: f32, z: f32) -> Self {
+impl Vec3Ext for pxl8_vec3 {
+    fn new(x: f32, y: f32, z: f32) -> Self {
         Self { x, y, z }
     }
 
-    pub fn dot(self, rhs: Self) -> f32 {
+    fn dot(self, rhs: Self) -> f32 {
         self.x * rhs.x + self.y * rhs.y + self.z * rhs.z
     }
 }
 
-impl Add for Vec3 {
+impl Default for pxl8_vec3 {
+    fn default() -> Self {
+        VEC3_ZERO
+    }
+}
+
+impl Add for pxl8_vec3 {
     type Output = Self;
     fn add(self, rhs: Self) -> Self {
-        Self::new(self.x + rhs.x, self.y + rhs.y, self.z + rhs.z)
+        Self {
+            x: self.x + rhs.x,
+            y: self.y + rhs.y,
+            z: self.z + rhs.z,
+        }
     }
 }
 
-impl Sub for Vec3 {
+impl Sub for pxl8_vec3 {
     type Output = Self;
     fn sub(self, rhs: Self) -> Self {
-        Self::new(self.x - rhs.x, self.y - rhs.y, self.z - rhs.z)
+        Self {
+            x: self.x - rhs.x,
+            y: self.y - rhs.y,
+            z: self.z - rhs.z,
+        }
     }
 }
 
-impl Mul<f32> for Vec3 {
+impl Mul<f32> for pxl8_vec3 {
     type Output = Self;
     fn mul(self, rhs: f32) -> Self {
-        Self::new(self.x * rhs, self.y * rhs, self.z * rhs)
+        Self {
+            x: self.x * rhs,
+            y: self.y * rhs,
+            z: self.z * rhs,
+        }
     }
 }